Remove logic that auto adds TLS when api key is enabled#1010
Merged
Conversation
cretz
approved these changes
Sep 16, 2025
Sushisource
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This PR removes logic that adds a default TLS config object when api key is enabled, but no TLS configuration was provided.
Why?
This makes the API semantics more clear.
Lang SDKs will now know:
Lang SDKs now know with certainty when to apply default TLS configuration to the client (generally this means
tls: truein the client config):api_keyis provided, but no TLS config was specified